Children finding their parents #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
force-pushed
the
2021-01-07-treating-orphans
branch
from
0503332 to
124a9f3
Compare
Anton-Latukha
force-pushed
the
2021-01-07-treating-orphans
branch
from
124a9f3 to
e935904
Compare
|
The #804 would free us from the |
Anton-Latukha
force-pushed
the
2021-01-07-treating-orphans
branch
from
574644b to
3c44459
Compare
Eq1 instance was previously derived as an orphan through TemplateHaskell. And that TH instance when moved into Nix.Value was breaking the NValue' data constructor deriving. So it is moved as derivable instance.
Since type class is up the structure - move instances there.
Anton-Latukha
force-pushed
the
2021-01-07-treating-orphans
branch
from
3c44459 to
ecab803
Compare
Anton-Latukha
force-pushed
the
2021-01-07-treating-orphans
branch
from
6cac906 to
8c6fb78
Compare
|
Upstreamed the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning instances according to the logical inheritance structure which is layed-out in the #778.
Since this PR is easier, waiting to be mergeable with #804. It changed some of the instances touched here.