Bugfix: ActionMailers with keyword args fail in Ruby 3.2.1#202
Open
marcrohloff wants to merge 1 commit intohashrocket:mainfrom
Open
Bugfix: ActionMailers with keyword args fail in Ruby 3.2.1#202marcrohloff wants to merge 1 commit intohashrocket:mainfrom
marcrohloff wants to merge 1 commit intohashrocket:mainfrom
Conversation
Member
|
@marcrohloff Thanks for the PR, however I think we'd be better off to cut a new release that removes support for Ruby < 3. 2.7 is at end of life. Also, do you have a scenario where this is failing or can you add a test case? |
Contributor
Author
|
@mattpolito The existing Mailer I agree that it would be good to remove support for earler Ruby (and Rails) versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where mailer methods defined with keyword args like
def test(user, notes:)fail with Ruby 3.2.1 and Rails 7.0.4