Skip to content

Conversation

drivera258
Copy link
Contributor

@drivera258 drivera258 commented Aug 13, 2025

Description

What does this PR do?

Non customer facing until parent component is completed & wired up

Per new designs - Creating a new 'Security' card component with toggle buttons as part of secret engine configuration tuning

Will currently live in its own component, but could be merged into parent component if we decide to go that route

Usage ---> <SecretEngine::SecurityCard @model={{this.model.secretsEngine}} />

Design Current Implementation (can change once put into parent comp)
image image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@drivera258 drivera258 added this to the 1.21.0-rc1 milestone Aug 13, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 13, 2025
Copy link

github-actions bot commented Aug 13, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

vercel bot commented Aug 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
vault-ui Ready Preview Comment Aug 13, 2025 4:31pm

@drivera258 drivera258 marked this pull request as ready for review August 13, 2025 16:32
@drivera258 drivera258 requested a review from a team as a code owner August 13, 2025 16:32
Copy link

Build Results:
All builds succeeded! ✅

@drivera258 drivera258 merged commit 3f30ca8 into main Aug 13, 2025
51 of 57 checks passed
@drivera258 drivera258 deleted the ui/VAULT-38722/create-security-card branch August 13, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants