🤖🤖🤖 d/aws_dx_connections: New data source

[BenjaminSaintCyr]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No. This PR adds a read-only data source only. It requires no IAM permissions beyond directconnect:DescribeConnections, which the existing aws_dx_connection data source already needs.

Description

Adds a new plural data source aws_dx_connections that returns every Direct Connect connection in the Region. The singular aws_dx_connection data source requires knowing a connection name up front and errors unless exactly one matches, so there is currently no way to enumerate connections.

• Returns connections, a list of objects each carrying arn, aws_device, bandwidth, id, location, name, owner_account_id, partner_name, provider_name, state, tags, and vlan_id.
• Takes no arguments: DescribeConnections has no server-side filter (its input accepts only a single connection ID), so callers filter in configuration with a for/for_each expression.
• Makes findConnections paginate, which affects two pre-existing callers. DescribeConnections is not modelled as paginated in the SDK but does return a nextToken, and the previous implementation read only the first page. This also fixes silent truncation past 100 connections for the aws_dx_connection data source and resource — a behaviour change beyond the scope the title implies, called out here rather than left in the diff.
• Exposes no synthetic top-level id, per the data-source naming guidance; each element carries its own id (the connection ID). A unit test pins this so it cannot regress.
• aws_device is populated from the API's awsDeviceV2 field, since awsDevice is deprecated and empty in practice. The model field is named AwsDeviceV2 so AutoFlex binds the correct one, while the public attribute name stays aws_device to match the singular data source.
• An empty result flattens to an empty list rather than null, so connections stays usable in for_each without try/coalesce. Likewise an untagged connection flattens tags to an empty map rather than null.
• Uses terraform-plugin-framework + aws-sdk-go-v2, with AutoFlex (fwflex.Flatten) for the per-item conversion and framework.DataSourceComputedListOfObjectAttribute for the nested schema.

Relations

Closes #40032

References

• AWS API Reference DescribeConnections: https://docs.aws.amazon.com/directconnect/latest/APIReference/API_DescribeConnections.html
• AWS SDK Go v2 DescribeConnections: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directconnect#Client.DescribeConnections
• AWS SDK Go v2 Connection type: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directconnect/types#Connection
• Existing singular data source: internal/service/directconnect/connection_data_source.go
• Shared finder: findConnections in internal/service/directconnect/connection.go

Output from Acceptance Testing

Run in us-west-2 with AWS_ALTERNATE_REGION=us-east-1, since the _empty and _region tests call acctest.PreCheckMultipleRegion(t, 2). The tests create and destroy real connections; they need no cross-connect or physical hardware, and a connection left in requested state accrues no port-hours.

% make testacc TESTS=TestAccDirectConnectConnectionsDataSource PKG=directconnect

--- PASS: TestAccDirectConnectConnectionsDataSource_empty (19.47s)
--- PASS: TestAccDirectConnectConnectionsDataSource_tags (24.84s)
--- PASS: TestAccDirectConnectConnectionsDataSource_basic (25.55s)
--- PASS: TestAccDirectConnectConnectionsDataSource_region (25.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      33.768s

Unit tests additionally cover pagination across page boundaries, the element-attribute contract, and the empty-list/empty-map flattening, with no credentials required:

% go test ./internal/service/directconnect/ -run 'TestConnectionsDataSource|TestFindConnections' -count=1 -v

--- PASS: TestConnectionsDataSourceSchema_noSyntheticID (0.00s)
--- PASS: TestFindConnectionsNoMatchIsNotAnError (0.00s)
--- PASS: TestFindConnectionsFilterSpansPages (0.00s)
--- PASS: TestFindConnectionsPaginates (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      9.817s

golangci-lint is clean across all five .ci/.golangci*.yml configs, semgrep is clean for the constants, naming and code-quality configs, providerlint is clean, swissshepherd reports All checks passed. for both documentation pages, and go generate ./internal/service/directconnect/ reproduces the generated files byte-for-byte.

---

AI Usage Disclosure

This pull request was prepared with assistance from an AI agent — specifically, a custom agent running inside Claude Code. The agent was configured for this repository (branching conventions, make gen awareness, no manual edits to _gen.go, smarterr patterns, AutoFlex, Framework patterns, acceptance-test scaffolding) and used for code generation, test authoring, and documentation. Every line has been reviewed by the human contributor, who has verified the code compiles and understands each design decision. Per the project's AI Usage Policy, "🤖🤖🤖" is included in the PR title.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.