-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Bug] Fix for Sagemaker Model VPCConfig changes attempt to update in place rather than force new #45491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix for Sagemaker Model VPCConfig changes attempt to update in place rather than force new #45491
Conversation
… on vpc config forced replacement on a vpc config change
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerModel_vpc\|TestAccSageMakerModel_basic' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMakerModel_vpc\|TestAccSageMakerModel_basic -timeout 360m -vet=off
2025/12/09 10:21:15 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/09 10:21:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccSageMakerModel_basic
=== PAUSE TestAccSageMakerModel_basic
=== RUN TestAccSageMakerModel_vpc
=== PAUSE TestAccSageMakerModel_vpc
=== RUN TestAccSageMakerModel_vpcConfigUpdate
=== PAUSE TestAccSageMakerModel_vpcConfigUpdate
=== CONT TestAccSageMakerModel_basic
=== CONT TestAccSageMakerModel_vpcConfigUpdate
=== CONT TestAccSageMakerModel_vpc
--- PASS: TestAccSageMakerModel_basic (16.27s)
--- PASS: TestAccSageMakerModel_vpc (25.48s)
--- PASS: TestAccSageMakerModel_vpcConfigUpdate (58.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 64.390s
YakDriver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
YakDriver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
@danielw-aws Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No
Description
Adds two tests to change VPC Config to ensure modification forces new on Subnet ID and Security Group. Changed Schema to add force new on VPCConfig object for model.go
Relations
Closes #45490
References
N/A
Output from Acceptance Testing