Skip to content

Conversation

@danielw-aws
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No

Description

Adds two tests to change VPC Config to ensure modification forces new on Subnet ID and Security Group. Changed Schema to add force new on VPCConfig object for model.go

Relations

Closes #45490

References

N/A

Output from Acceptance Testing

make testacc TESTS=TestAccSageMakerModel_vpcVpcConfigUpdate PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-model-vpc-config-force-new 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerModel_vpcVpcConfigUpdate'  -timeout 360m -vet=off
2025/12/05 13:02:22 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 13:02:22 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerModel_vpcVpcConfigUpdate
=== PAUSE TestAccSageMakerModel_vpcVpcConfigUpdate
=== CONT  TestAccSageMakerModel_vpcVpcConfigUpdate
--- PASS: TestAccSageMakerModel_vpcVpcConfigUpdate (53.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  59.510s

… on vpc config forced replacement on a vpc config change
@danielw-aws danielw-aws requested a review from a team as a code owner December 8, 2025 19:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Dec 8, 2025
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2025
@ewbankkit ewbankkit self-assigned this Dec 9, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 9, 2025
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Dec 9, 2025
ewbankkit
ewbankkit previously approved these changes Dec 9, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerModel_vpc\|TestAccSageMakerModel_basic' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerModel_vpc\|TestAccSageMakerModel_basic -timeout 360m -vet=off
2025/12/09 10:21:15 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/09 10:21:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerModel_basic
=== PAUSE TestAccSageMakerModel_basic
=== RUN   TestAccSageMakerModel_vpc
=== PAUSE TestAccSageMakerModel_vpc
=== RUN   TestAccSageMakerModel_vpcConfigUpdate
=== PAUSE TestAccSageMakerModel_vpcConfigUpdate
=== CONT  TestAccSageMakerModel_basic
=== CONT  TestAccSageMakerModel_vpcConfigUpdate
=== CONT  TestAccSageMakerModel_vpc
--- PASS: TestAccSageMakerModel_basic (16.27s)
--- PASS: TestAccSageMakerModel_vpc (25.48s)
--- PASS: TestAccSageMakerModel_vpcConfigUpdate (58.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	64.390s

YakDriver
YakDriver previously approved these changes Dec 9, 2025
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit dismissed stale reviews from YakDriver and themself via 6069de1 December 9, 2025 16:24
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit
Copy link
Contributor

@danielw-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 85d523d into hashicorp:main Dec 9, 2025
36 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.26.0 milestone Dec 9, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 10, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. partner Contribution from a partner. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sagemaker Model VPCConfig changes attempt to update in place rather than force new

3 participants