Skip to content

Conversation

@tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Dec 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR adds the storage_configuration.s3_vectors_configuration block to support S3 Vectors knowledge bases.

AWS API Behavior and Provider Implementation

  • Within the storage_configuration.s3_vectors_configuration block:

    • Although not explicitly documented, either index_arn, or both index_name and vector_bucket_arn must be specified.
      This behavior is based on verification and is enforced via validators and documented accordingly.
    • All arguments in this block are marked as ForceNew.
      • According to the CloudFormation documentation for this resource, updates to these arguments require replacement.
  • Note: r/aws_bedrockagent_knowledge_base: Additional knowledge_base_configuration and storage_configuration options #45465 edits the same files for a similar purpose (but without overlapping changes), which may cause merge conflicts.

Relations

Closes #45395
Relates #45465

References

https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent_CreateKnowledgeBase.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-bedrock-knowledgebase-s3vectorsconfiguration.html

Output from Acceptance Testing

$ make testacc TESTS='TestAccBedrockAgent_serial/KnowledgeBase/(basic|S3Vectors)' PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_bedrockagent_knowledge_base-add_s3_vectors_configuration 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgent_serial/KnowledgeBase/(basic|S3Vectors)'  -timeout 360m -vet=off
2025/12/06 12:10:14 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/06 12:10:14 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/S3Vectors
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basic
--- PASS: TestAccBedrockAgent_serial (1618.90s)
    --- PASS: TestAccBedrockAgent_serial/KnowledgeBase (1618.90s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/S3Vectors (62.96s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/basic (1555.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       1623.252s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. labels Dec 6, 2025
@tabito-hara tabito-hara marked this pull request as ready for review December 6, 2025 03:59
@tabito-hara tabito-hara requested a review from a team as a code owner December 6, 2025 03:59
@ewbankkit ewbankkit self-assigned this Dec 8, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 8, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for S3 Storage configuration in aws_bedrockagent_knowledge_base

2 participants