route53domains: make privacy fields optional/computed to avoid forced…

[stiliajohny]

Title

route53domains: make privacy fields optional/computed to avoid forced API calls

Description

Removes Default=true from admin_privacy, billing_privacy, registrant_privacy, and tech_privacy in the aws_route53domains_registered_domain resource.

Previously, these attributes always defaulted to true, which forced Terraform to call UpdateDomainContactPrivacy even when privacy is not supported by the TLD (e.g. .cz, .eu). This resulted in 400 InvalidInput errors during apply.

With this change, the privacy fields are now Optional+Computed. Terraform will:

• Only manage privacy if a value is explicitly set in configuration.
• Otherwise, treat AWS as the source of truth and skip unsupported API calls.

This prevents errors for unsupported TLDs while preserving full functionality for TLDs that allow privacy management.

Relations

Closes #44538

References

• AWS CZ route 53 docs: https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/cz.html
• AWS Route 53 Domains docs: https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/domain-privacy-protection.html
• Provider PR guidelines: https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/

Rollback Plan

If needed, revert this commit and reintroduce Default=true for the privacy fields. This will restore prior behavior (always managing privacy), but may reintroduce errors for unsupported TLDs.

Changes to Security Controls

No changes to access controls, encryption, or logging. This change only affects how Terraform decides whether to call UpdateDomainContactPrivacy.

Output from Acceptance Testing

N/A

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

⚠️ Our automation has detected the following potential issues with your pull request

---

❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.