Fix broken builds against Go 1.6 and 1.7 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using sort.Slice when building against Go 1.6 or 1.7, instead using the older sort.Sort interface. Signed-off-by: Free Ekanayaka <[email protected]>
freeekanayaka
force-pushed
the
go-1.6-and-1.7-compatibility
branch
from
d114cb8 to
1ab04fd
Compare
Author
|
Hello, was this PR considered for merging? I think it's a trivial fix that makes github.com/hashicorp/raft buildable again with Go 1.6, which regressed due to this go-metrics issue (I have an app that requires to be buildable with Go 1.6 and that depends on hashicorp's raft, and hence on go-metrics). Tahnks |
|
Could this be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using sort.Slice when building against Go 1.6 or 1.7, instead
using the older sort.Sort interface. Fixes #59.