chore: 🤖 use statically referenced components for host form #3072
+52
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashicc
commented
Nov 17, 2025
Comment on lines
+3
to
+13
| import { | ||
| TYPE_HOST_CATALOG_PLUGIN_AWS, | ||
| TYPE_HOST_CATALOG_PLUGIN_AZURE, | ||
| TYPE_HOST_CATALOG_PLUGIN_GCP, | ||
| TYPE_HOST_CATALOG_STATIC, | ||
| } from 'api/models/host-catalog'; |
Collaborator
Author
There was a problem hiding this comment.
These are being imported from host-catalog but since the host's composite type is derived from these it seems alright to use these constants
hashicc
commented
Nov 17, 2025
| have a model and this else part is required to prevent | ||
| erroring out here. This has been noted in the tech debt doc to further investigate }} | ||
| {{component | ||
| (concat 'form/host/' 'static') |
Collaborator
Author
There was a problem hiding this comment.
This didn't have to use the dynamic component helper before since the concat is only using known strings
hashicc
force-pushed
the
migrate-component-helper-host-form
branch
from
6c7ab2e to
151791d
Compare
hashicc
force-pushed
the
migrate-component-helper-host-form
branch
from
bcef057 to
1022c8a
Compare
ZedLi
approved these changes
Nov 17, 2025
priya-patel04
approved these changes
Nov 18, 2025
hashicc
force-pushed
the
migrate-component-helper-host-form
branch
from
1022c8a to
46554ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr continues the migration away from the dynamic
{{component}}helper. More information in #2880. This pull request focuses on migrating the host form component.How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.