Llb/rdp client launch #3058
Open
Llb/rdp client launch #3058
+1,401
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DhariniJeeva
force-pushed
the
llb/rdp-client-launch
branch
from
92be47c to
c5ba116
Compare
Collaborator
priya-patel04
left a comment
priya-patel04
left a comment
There was a problem hiding this comment.
Everything looks good! Excited to get this in 🎉
I missed updating few magic strings - I have small PR covering it
priya-patel04
previously approved these changes
Nov 13, 2025
* feat: 🎸 added a new RDP service * fix: 🐛 rdp test * refactor: 💡 update error handling for fetching rdp clients * refactor: 💡 addressed comments * fix: 🐛 revert private field * refactor: 💡 addressed comments * refactor: 💡 updated rdp clients to array of strings
* feat: 🎸 preferred clients section on settings page * chore: 🤖 update mock ipc with new handlers * refactor: 💡 moved windows rdp protocol to const * refactor: 💡 moved rdp calls to app route * test: 💍 fixed failings tests * refactor: 💡 addressed comments * fix: 🐛 fixed failing tests * refactor: 💡 add mock rdp service calls to tests * refactor: 💡 addressed comments * test: 💍 add additional tests * refactor: 💡 fixed test failure
* feat: 🎸 preferred clients section on settings page * refactor: 💡 moved rdp calls to app route * test: 💍 fixed failings tests * refactor: 💡 addressed comments * fix: 🐛 fixed failing tests * refactor: 💡 add mock rdp service calls to tests * feat: 🎸 adds open button to session details page * fix: 🐛 translation string * refactor: 💡 address feedback * refactor: 💡 address comment * fix: 🐛 test failure
* test: 💍 e2e test for rdp client launch * test: 💍 added rdp test helper * refactor: 💡 misc * refactor: 💡 addressed comments * refactor: 💡 removed similar test
* refactor: 💡 updated logic to store preferred rdp client * refactor: 💡 simplified preferred client logic
DhariniJeeva
force-pushed
the
llb/rdp-client-launch
branch
from
a6699ed to
3c763ed
Compare
priya-patel04
approved these changes
Nov 17, 2025
lisbet-alvarez
approved these changes
Nov 18, 2025
Collaborator
lisbet-alvarez
left a comment
lisbet-alvarez
left a comment
There was a problem hiding this comment.
Looks good! Also tested in mac + windows! 🎉
ZedLi
reviewed
Nov 18, 2025
| app.on('quit', () => { | ||
| cacheDaemonManager.stop(); | ||
| // we should stop any active RDP client processes | ||
| rdpClientManager.stopAll(); |
Collaborator
There was a problem hiding this comment.
It looks like we don't stop the processes when we logout but still kill the sessions, should we have killed the RDP processes as well on logout?
Collaborator
Author
There was a problem hiding this comment.
good point, I think we should do the same for logout as well. I will raise a pr to address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all the commits for RDP client launch work.
Screenshots (if appropriate)
How to Test
DM me or @priya-patel04 for cluster url
To test setting page functionality:
Navigate to Settings page and verify a new Preferred Clients section is rendered
Test updating your preferred client to None. Reopen the app and verify None selection persists.
To test Target and details page
Openfor one of the RDP targets, it should launch Windows App for Mac and Mstc if you are testing this on Windows osTo test Session details page
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.