Skip to content

Removed copy call from mpl.rcParams for params update when using defaults.#1083

Merged
has2k1 merged 1 commit into
has2k1:mainfrom
zhymirt:theme_matplotlib_default_rc_fix
Jun 23, 2026
Merged

Removed copy call from mpl.rcParams for params update when using defaults.#1083
has2k1 merged 1 commit into
has2k1:mainfrom
zhymirt:theme_matplotlib_default_rc_fix

Conversation

@zhymirt

@zhymirt zhymirt commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The copy method for Matplotlib's rcParams creates a raw copy without resolving the backend. Calling update directly on the default rcParams causes the backend to resolve before copying the value over.

Closes #1071

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.16%. Comparing base (17eeeb6) to head (9c16a3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         208      208           
  Lines       14375    14375           
  Branches     1796     1796           
=======================================
  Hits        12530    12530           
  Misses       1272     1272           
  Partials      573      573           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@has2k1 has2k1 merged commit f6f5cb4 into has2k1:main Jun 23, 2026
9 checks passed
@has2k1

has2k1 commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Thank you @zhymirt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plotting with Matplotlib theme gives error

2 participants