[UI] Call XInitThreads before wxEntry on Linux - #264
Open
Azkali wants to merge 1 commit into
Open
Conversation
The Linux entry point pins GTK to the X11 backend but never makes Xlib thread safe. Mesa's Vulkan X11 WSI runs a present queue thread that issues xcb requests on the same display connection, so Xlib calls from the UI thread race it and abort with xcb_io.c poll_for_event: Assertion !xcb_xlib_threads_sequence_lost. Reproduced on every title launch on Fedora 44 aarch64 (Ayaneo Pocket DS, Turnip under Xwayland).
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux entry point pins GTK to the X11 backend but never makes Xlib thread safe. Mesa's Vulkan X11 WSI runs a present queue thread that issues xcb requests on the same display connection, so Xlib calls from the UI thread race it and abort with
xcb_io.c poll_for_event: Assertion !xcb_xlib_threads_sequence_lost.Reproduced on every title launch on Fedora 44 aarch64 (Ayaneo Pocket DS, Turnip under Xwayland). With this change the same setup launches reliably.