Repository navigation
Port the bug bash repro and charter wording from upstream (#1601) - #1547
Merged
Merged
Conversation
Repro tests are written from the finding as ActAsync steps and a closing AssertAsync, so confirming a bug needs no locators. Verifiers confirm a bug when its repro fails on the reported defect. Charters get about fifteen minutes (--max-steps 15, --timeout 900000). Under a time limit the bash keeps running new charters and reports each bug as it is confirmed. An account with a password under 6 characters is called out before the config fails. Closes #1510 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1510
Ports upstream commit 0f158a3 (e2e-inc/e2e#1601), docs only: the bug bash repro tests are written from the finding as
Agent.ActAsyncsteps with a closingAgent.AssertAsync, a finding is confirmed when its repro fails on the reported defect, charters get about fifteen minutes (--max-steps 15 --timeout 900000), a time-limited bash keeps running charters and reports bugs as they are confirmed, and the password-length note is explained.Changed:
skills/e2e-dotnet/references/bug-bash.mddocs-site/src/content/docs/docs/bug-bash.mdxskills/create-verification-skill/SKILL.mdskills/create-verification-skill/references/example/verify-todomvc/SKILL.mdUpstream parity
Upstream change: tester-army/e2e commit
0f158a3(#1601).Counts: ported 8 (the bug-bash repro and verify steps, charter budget, time-limit rule, report re-run, password note, docs page steps 6 and 7, the two verification-bar sentences); renamed 0; partial 1; missing 0; port-only 0.
Justified exceptions (not ported):
docs/reference/mcp.mdxsentence about bug-bash sessions: the .NET MCP reference has no bug-bash line, so there is nothing to port.SKILL.example.mdinreferences/example/verify-playground: the .NET port has no such file;verify-todomvcis its example and is updated..changesetdirectory.--outputdirectory sentence:dotnet testhas no--outputflag, so the repro step runs the class alone. Partial, named here.Contract sentences checked: "fails with
ASSERTION_FAILEDfrom the closing assert" is in the verify step and the docs page; "a failed act whose message names the defect" is in the verify step. No error codes added upstream. No tests changed (docs only).Repo rules (CLAUDE.md): public surface changed in docs, so skill and docs-site are updated together. No real-model test run: docs-only change.
/code-reviewrun on this PR.🤖 Generated with Claude Code