Repository navigation
Translate the engine error of every fixture call, not only Browser steps - #1140
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
Appcall that timed out or lost its session threw the raw engine error, with no runner code and no word on which call it was. Now every fixture call maps the engine error it throws onto the runner taxonomy, asBrowsersteps already did (#1119): a timeout readsoperation timed out in app.open /orders, a lost session isAPP_NOT_OPEN.Browser.OnDialogAsyncand the download waits now ask for the browser session inside their step, so a missing one is aConfigurationException, as inGotoAsync.A missing browser engine in those three calls is now a failed recorded step (it threw before any step existed). A caller's cancel on a web session is
CANCELLEDand now readsoperation cancelled, as upstream'stranslateEngineErrordoes (see #1121). AnOperationCanceledExceptionstays a cancel.Upstream change ported
e2e-inc/e2e#1505 (
bdf769bc270061b93f11847c204a9d40de737bc4):translated(call, body)inpackages/e2e/src/run/fixture-recording.ts, which wraps every fixture call. It lives inFixtureRecording.Translated, used byBrowser,App, and the device fixtures (EngineFixtureContext.RunOperationAsync, upstream'sFixtureRecorder.run).Partial / skipped tests
FixtureRuntime/ExplicitFixtureOperationsTests/Partial_Maps_an_EngineError_a_contributed_method_throws...ports upstream'sitoffixture-runtime.test.ts. It is partial: the port has nocontext.fixture(...)declaration, so the calls go throughRunOperationAsync. Upstream's otherits of that describe declare fixtures and are not ported.ScreenshotNavigationtimeout test: upstream calls the surface; the port goes throughApp, so it now expectsACTION_FAILEDwith the engine'sOPERATION_TIMEOUTas its cause.AppSteeringHooks/App_open_keeps_the_engines_own_reason_it_cannot_launchnow expectsConfigurationException(same code and message), as upstream's categoryconfiguration..NET-only
FixtureRecording(file and class): home for upstream'stranslated; the port has noFixtureRecorder.it:App_steps_map_the_engine_error...(App records its steps itself here) andBrowser_calls_that_need_a_browser_engine_report_a_configuration_error_inside_their_step.translateLocatorError); not changed.User-visible message change: COMPATIBILITY.md, SKILL.md, and
docs-site/.../migrate/playwright.mdxare updated. No public API change.Closes #1120
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK