Repository navigation
Throw on inputValue and isChecked of the wrong element; uncheck clicks ARIA radios - #1114
Merged
Merged
Conversation
…dios on uncheck Ports e2e-inc/e2e#1552 (d2556bc). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputValueAsync()on a heading used to return"", andIsCheckedAsync()on a button used to returnfalse. Both hid a wrong locator. Now they throwACTION_FAILED, as Playwright does. A field with no value still reads"", and a checkable role with no state still readsfalse.UncheckAsync()on arole="radio"now clicks it, as Playwright does; a native radio still refuses.Breaking: code that relied on
""orfalsefrom a node that cannot hold a value or a checked state now getsACTION_FAILED. This follows upstream'sfeat!. No public signature changes.Upstream: e2e-inc/e2e#1552, commit d2556bc.
Ported tests: check-actions (two ARIA radio tests, element and locator target), scripted-reads, locator-basics (
inputValueclass new,isCheckedchanged), and the testbedcheckandlocator-conveniencetests, which lose their known-difference markers. Upstream's secure-fieldisCheckedassertion is dropped as upstream drops it; the port's own secure-field test drops it too..NET-only:
NodeStates.CheckedReported: the port reads the checked state as a plainbool, where upstream readsstates.checked !== undefined.Checkedsets it. The web, mobile, Windows and document engines fill it.Roles.IsValueControlandRoles.IsCheckablemap to upstreamisValueControlandisCheckable.PageScript.RadioKindis upstream'sradioKind.Docs updated: Locator API reference, errors and Playwright migration guides, the skill writing-tests reference, COMPATIBILITY.md.
Closes #1094
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK