Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
@coderabbitai review |
Contributor
Action not completed
|
Member
Author
|
Merged into #1091: both PRs must land together because each needs the other's marker removals to pass CI. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two frame tests had a "known difference" marker because a frame-scoped
getByRolealso matched the nested frame's button (#1066). That is fixed on main, so both tests now pass and fail as stale markers. This removes the markers:getBy coverage (role, text, test id, label, placeholder)inLocatorFrameandshould work for $evalinSelectorsFrame. Both run as normal tests with their upstream assertions.Upstream change: e2e-inc/e2e#1505 (
bdf769b),apps/testbed/tests/locator-frame.e2e.tsandselectors-frame.e2e.ts. No source, docs or COMPATIBILITY.md change: nothing there mentions #1066.Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK