Skip to content

Run the nested-frame role tests as normal tests (Refs #1060) - #1092

Closed
kblok wants to merge 1 commit into
mainfrom
issue-1060-drop-frame-markers
Closed

kblok wants to merge 1 commit into
mainfrom
issue-1060-drop-frame-markers

Conversation

@kblok

@kblok kblok commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Two frame tests had a "known difference" marker because a frame-scoped getByRole also matched the nested frame's button (#1066). That is fixed on main, so both tests now pass and fail as stale markers. This removes the markers: getBy coverage (role, text, test id, label, placeholder) in LocatorFrame and should work for $eval in SelectorsFrame. Both run as normal tests with their upstream assertions.

Upstream change: e2e-inc/e2e#1505 (bdf769b), apps/testbed/tests/locator-frame.e2e.ts and selectors-frame.e2e.ts. No source, docs or COMPATIBILITY.md change: nothing there mentions #1066.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 332c5a4 and 13af76f.

Files selected for processing: 2

  • tests/E2E.NUnit.Tests/LocatorFrame/LocatorFrameTests.cs
  • tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Merged into #1091: both PRs must land together because each needs the other's marker removals to pass CI. Closing.

@kblok kblok closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant