You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Assert the real value in the selectors-text strict mode test - #1087
#1065 fixed the inline text match, so the selectors-text test that had to run behind ExpectedToFailAsync can assert the real value now. HasText_and_internal_text_should_match_full_node_text_in_strict_mode runs as upstream wrote it: the first GetByText("hello") match on <span id=span1>hello</span>world has the idspan1. The stale note about #1062 is gone from COMPATIBILITY.md.
Upstream change ported.e2e-inc/e2e#1505, commit bdf769b: apps/testbed/tests/selectors-text.e2e.ts, the hasText and internal:text should match full node text in strict mode test, no longer a known difference. ExpectedToFailAsync stays only where upstream marks fail.
No actionable comments were generated in the recent review.
Walkthrough
The selectors-text test now checks both DOM cases with direct assertions instead of ExpectedToFailAsync. The compatibility note no longer lists the test as a known difference and describes the wrapper’s expected-failure behavior.
Changes: Selectors text assertions
Layer / File(s)
Summary
Direct strict-mode assertions tests/E2E.NUnit.Tests/SelectorsText/SelectorsTextTests.cs, COMPATIBILITY.md
The test directly checks text matches, element IDs, and match count. The compatibility note describes how ExpectedToFailAsync handles expected failures and unexpected passes.
hardkoded/e2e-dotnet#710: This PR adds locator and text-filter behavior that the selectors-text test exercises.
Merge Risk: Minimal · up to 5d909
No actionable merge-blocking risk is identified. The change is mergeable subject to normal test checks.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Assert the real value in the selectors-text strict mode test" matches the main change. The SelectorsTextTests.cs test HasText_and_internal_text_should_match_full_node_text_in_strict_mode no…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Upstream Parity
The check does not apply. The supplied PR description is x and names no tester-army/e2e commit, upstream pull request, or upstream file. The context provides only a reference to issue #1060, not iss…
Full details: Title check
Explanation
The title "Assert the real value in the selectors-text strict mode test" matches the main change. The SelectorsTextTests.cs test HasText_and_internal_text_should_match_full_node_text_in_strict_mode no longer wraps its DOM cases in ExpectedToFailAsync and now asserts the real text, element IDs, and hello match count directly. The title is specific, concise, and free of noise.
Full details: Upstream Parity
Explanation
The check does not apply. The supplied PR description is x and names no tester-army/e2e commit, upstream pull request, or upstream file. The context provides only a reference to issue #1060, not issue text naming an upstream change.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped tester-army/e2e.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1065 fixed the inline text match, so the
selectors-texttest that had to run behindExpectedToFailAsynccan assert the real value now.HasText_and_internal_text_should_match_full_node_text_in_strict_moderuns as upstream wrote it: the firstGetByText("hello")match on<span id=span1>hello</span>worldhas theidspan1. The stale note about #1062 is gone from COMPATIBILITY.md.Upstream change ported. e2e-inc/e2e#1505, commit
bdf769b:apps/testbed/tests/selectors-text.e2e.ts, thehasText and internal:text should match full node text in strict modetest, no longer a known difference.ExpectedToFailAsyncstays only where upstream marksfail.No new symbols, no public API change.
Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Summary by CodeRabbit