Skip to content

Assert the real value in the selectors-text strict mode test - #1087

Closed
kblok wants to merge 1 commit into
mainfrom
issue-1060-selectors-text-real
Closed

kblok wants to merge 1 commit into
mainfrom
issue-1060-selectors-text-real

Conversation

@kblok

@kblok kblok commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

#1065 fixed the inline text match, so the selectors-text test that had to run behind ExpectedToFailAsync can assert the real value now. HasText_and_internal_text_should_match_full_node_text_in_strict_mode runs as upstream wrote it: the first GetByText("hello") match on <span id=span1>hello</span>world has the id span1. The stale note about #1062 is gone from COMPATIBILITY.md.

Upstream change ported. e2e-inc/e2e#1505, commit bdf769b: apps/testbed/tests/selectors-text.e2e.ts, the hasText and internal:text should match full node text in strict mode test, no longer a known difference. ExpectedToFailAsync stays only where upstream marks fail.

No new symbols, no public API change.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

Summary by CodeRabbit

  • Bug Fixes
    • Updated a ported page test to validate text matching directly, including matched text, element IDs, and match counts.
  • Documentation
    • Clarified how expected-to-fail assertions are handled in the test suite.

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The selectors-text test now checks both DOM cases with direct assertions instead of ExpectedToFailAsync. The compatibility note no longer lists the test as a known difference and describes the wrapper’s expected-failure behavior.

Changes: Selectors text assertions

Layer / File(s) Summary
Direct strict-mode assertions
tests/E2E.NUnit.Tests/SelectorsText/SelectorsTextTests.cs, COMPATIBILITY.md
The test directly checks text matches, element IDs, and match count. The compatibility note describes how ExpectedToFailAsync handles expected failures and unexpected passes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 5d909

No actionable merge-blocking risk is identified. The change is mergeable subject to normal test checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Assert the real value in the selectors-text strict mode test" matches the main change. The SelectorsTextTests.cs test HasText_and_internal_text_should_match_full_node_text_in_strict_mode no…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Upstream Parity Passed The check does not apply. The supplied PR description is x and names no tester-army/e2e commit, upstream pull request, or upstream file. The context provides only a reference to issue #1060, not iss…
Full details: Title check

Explanation

The title "Assert the real value in the selectors-text strict mode test" matches the main change. The SelectorsTextTests.cs test HasText_and_internal_text_should_match_full_node_text_in_strict_mode no longer wraps its DOM cases in ExpectedToFailAsync and now asserts the real text, element IDs, and hello match count directly. The title is specific, concise, and free of noise.

Full details: Upstream Parity

Explanation

The check does not apply. The supplied PR description is x and names no tester-army/e2e commit, upstream pull request, or upstream file. The context provides only a reference to issue #1060, not issue text naming an upstream change.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped tester-army/e2e.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4b3025f and 5d909d3.

Files selected for processing: 2
  • COMPATIBILITY.md
  • tests/E2E.NUnit.Tests/SelectorsText/SelectorsTextTests.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Main already has this fix (merged with #1069). Closing.

@kblok kblok closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant