Skip to content

Quote a glob in a pattern step label, as upstream's patternLabel (Refs #1060) - #1082

Merged
kblok merged 2 commits into
mainfrom
issue-1060-pattern-label
Nov 4, 2026
Merged

kblok merged 2 commits into
mainfrom
issue-1060-pattern-label

Conversation

@kblok

@kblok kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member

A step or error that names a URL pattern now quotes a glob string, as upstream does: browser.waitForURL "**/a" instead of browser.waitForURL **/a. A regex still reads as /source/flags. The label is the same one for waitForURL, route, unroute and waitForResponse.

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b: patternLabel in packages/web/src/browser.ts (used by waitForURL, route, unroute, waitForResponse). The port's Routes.Label was the String(pattern) arrow it replaces; it is now Routes.PatternLabel.

Not ported: the second part of the commit, translated(call, ...) in packages/e2e/src/run/fixture-recording.ts and the wait case of its unit test in fixture-runtime.test.ts ("maps an EngineError a contributed method throws onto the runner taxonomy..."). The port has no FixtureRecorder and its browser calls do not wrap engine timeouts in a translated message, so there is no code to change and the it cannot be ported.

.NET-only: PatternLabelTests (E2E.Tests/RoutePattern) checks the label alone, because the upstream it needs FixtureRecorder. COMPATIBILITY.md is updated; there is no public API change.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 77f48c2 and 78a1aad.

Files selected for processing: 4
  • COMPATIBILITY.md
  • src/E2E/Internal/Routes.cs
  • src/E2E/Run/Browser.cs
  • tests/E2E.Tests/RoutePattern/PatternLabelTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit df2ee00 into main Nov 4, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-pattern-label branch November 4, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant