feat: track request IP addresses in modal preview server#141
Open
feat: track request IP addresses in modal preview server#141
Conversation
Add a lightweight Starlette reverse-proxy in front of the FastAPI backend that logs every request's client IP address. - Backend moved to internal port 10001 - IP-tracking proxy runs on exposed port 10000 - Extracts real IP from X-Forwarded-For / X-Real-IP headers - Supports SSE/streaming responses (e.g. /chat endpoint) - Logs lines like: REQUEST 1.2.3.4 GET /sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add IP address logging for every incoming request to the Modal preview server.
Changes
A lightweight Starlette reverse-proxy is inserted between Modal's exposed port (10000) and the FastAPI backend (moved to internal port 10001). The proxy:
X-Forwarded-For/X-Real-IPheaders (set by Modal's proxy layer), falling back torequest.client.hostREQUEST 1.2.3.4 GET /sessions/RESPONSE 1.2.3.4 GET /sessions -> 200/chatendpoint) viahttpxstreaming APIArchitecture
Only
modal_preview.pyis modified. No changes toserver/server.pyor other files.Testing
py_compilepasseshttpx,uvicorn,starletteare already in the image)