fix(ci): patch rustls for RUSTSEC-2026-0285 and unbreak the Android SDK setup - #766
Merged
Merged
Conversation
rustls 0.23.40 accepts TLS 1.3 handshake messages across encryption level boundaries, which fails the Cargo Audit job. Bump the transitive pin in Cargo.lock to the patched 0.23.45 (rustls-webpki follows to 0.103.15). Every dependent (reqwest, hyper-rustls, tokio-rustls, sentry) accepts ^0.23, so no Cargo.toml change is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 548 548
Lines 22584 22584
Branches 2467 2467
=======================================
Hits 22516 22516
Misses 17 17
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
setup-android installs `tools platform-tools` by default, but the runner's cmdline-tools 16.0 no longer carries the legacy `tools` package, so sdkmanager exits 1 and Build / Android fails on every PR. Request platform-tools only. The newest action release keeps the same default, so bumping it would not help.
hamidfzm
enabled auto-merge (squash)
September 15, 2026 16:09
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated CI breakages currently fail every PR. This fixes both.
Cargo Audit. RUSTSEC-2026-0285 was published:
rustls0.23.40 incorrectly accepts TLS 1.3 handshake messages across encryption level boundaries (fixed in >= 0.23.45). This bumps the transitiverustlspin insrc-tauri/Cargo.lockto 0.23.45, the newest 0.23.x release.rustlsreaches Glyph throughreqwest0.12 (viasentryandtauri-plugin-http),hyper-rustls, andtokio-rustls. All of them accept^0.23, so no dependent caps it below the fix and noCargo.tomlchange is needed.Build / Android.
android-actions/setup-androidinstallstools platform-toolsby default. The ubuntu runner image now ships cmdline-tools 16.0, which no longer carries the legacytoolspackage, so the step dies withWarning: Failed to find package 'tools'andsdkmanager ... failed with exit code 1. The same failure hits #764 and #765. The latest release of the action (v4.0.1) still has that default, so bumping it would not help; the step now requestsplatform-toolsonly. The NDK is still installed by the following step, and Gradle fetches the platform and build tools it needs.Changes
src-tauri/Cargo.lock:rustls0.23.40 -> 0.23.45 (cargo update -p rustls --precise 0.23.45), withrustls-webpki0.103.13 -> 0.103.15 pulled along.github/workflows/ci-build.yml: passpackages: platform-toolstosetup-androidso it stops requesting the removedtoolspackageRisk classification
Invariants at stake and evidence
Network: patch-level bump of the TLS stack used by outbound HTTPS (Sentry reporting and
tauri-plugin-http). No API or config change; the patch releases only tighten handshake validation. Evidence:cargo auditinsrc-tauri/before:error: 1 vulnerability found!(RUSTSEC-2026-0285, rustls 0.23.40). After: exit 0, no vulnerabilities, only the existing allowed warnings (unmaintainedfxhash,proc-macro-error,unic-*, andglibunsoundness).pnpm typecheck && pnpm check && pnpm test,cargo test --lib, andcargo clippy --all-targets -- -D warnings.Build / Androidcheck on this PR is its evidence.Testing
Local gates and
cargo auditon Windows; CI covers the other platforms and the Android build.Screenshots
N/A