Convert some other local mutators and visitors to mutate_with and visit_with #8894
+442
−670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Dec 8, 2025
| [&](auto *self, const For *op) { | ||
| // At this stage of lowering, loop_min and loop_max | ||
| // conveniently exist in scope. | ||
| Interval in(Variable::make(Int(32), op->name + ".loop_min"), |
Member
There was a problem hiding this comment.
FYI: This is likely to have a merge conflict with #8858
abadams
reviewed
Dec 9, 2025
| private: | ||
| Stmt inject_marker(const Stmt &stmt, const string &func, const Stmt &last_use) { | ||
| bool injected = false; | ||
| return mutate_with(stmt, [&](auto *self, const Block *block) -> Stmt { |
Member
There was a problem hiding this comment.
do_injection could take a const Stmt & (an inefficiency, if it is one, also exists in the original). I can't figure out why clang-tidy isn't complaining about it already. Is there something I'm missing?
Member
|
There are some clang-tidy things to fix, but I believe the failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concurrent complement to #8893
AddAtomicMutex.cpp is a little scary, actually.