fix: unregister FileProvider domain before deleting account/repos#491
Draft
dkam wants to merge 2 commits into
Draft
fix: unregister FileProvider domain before deleting account/repos#491dkam wants to merge 2 commits into
dkam wants to merge 2 commits into
Conversation
On macOS, when an account is removed or repos are deleted, the FileProvider domain was not being unregistered. This left the FileProvider extension trying to signal enumerator updates for domains that no longer exist, causing "Couldn't communicate with a helper application" errors and crashing the background daemon. Fix by calling unregisterDomain() / fileProviderRemoveDomain() before deleting the account data, so macOS cleanly tears down the FileProvider state.
dkam
marked this pull request as draft
April 17, 2026 02:27
The FileProvider API is macOS-only; without the guard this breaks the Linux/Windows build with an undefined symbol. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Found this while debugging FileProvider crashes in the SeaDrive logs. The unregisterDomain / fileProviderRemoveDomain functions exist but are never called during account removal or repo cleanup on macOS. Builds cleanly on macOS (Qt 6.11, Apple Clang 21, arm64) but I haven't been able to test the FileProvider integration end-to-end — would appreciate review from someone who can.
On macOS, when an account is removed or repos are deleted, the FileProvider domain was not being unregistered. This left the FileProvider extension trying to signal enumerator updates for domains that no longer exist, causing "Couldn't communicate with a helper application" errors and crashing the background daemon.
Fix by calling unregisterDomain() / fileProviderRemoveDomain() before deleting the account data, so macOS cleanly tears down the FileProvider state.