Repository navigation
Conversation
Waiting jobs in the Generate HACS Data workflow now send the Slack notification only when the job name starts with "Publish ". Other workflows are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YBrtn9mBrHxYa1Gbk2S5Hr
There was a problem hiding this comment.
🟢 Approval recommended
The narrow filter matches the stated requirements, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Limits Slack notifications for the “Generate HACS Data” workflow to jobs whose names start with Publish .
Changes:
- Adds an early return for non-publish jobs before constructing or sending Slack messages.
- Leaves notifications for other workflows unchanged.
| File | Description |
|---|---|
src/plugins/workflow_job.waiting.slack.ts |
Filters out non-publish HACS Data jobs. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a filter to prevent Slack notifications from being sent for certain workflow jobs in the "Generate HACS Data" workflow.
Changes
This ensures that only "Publish" jobs from the HACS Data generation workflow trigger Slack notifications, while other jobs in that workflow are silently skipped.
Implementation Details
The filter is placed early in the execution flow, before the Slack message is constructed and sent, ensuring efficient early exit for non-matching jobs.
https://claude.ai/code/session_01YBrtn9mBrHxYa1Gbk2S5Hr