Skip to content

Conversation

@MubeenMohammed
Copy link

Tickets:

  • HAC-

List of changes:

  • Some minor fixes to the package.json, database.service.js, and env.service.js files to accommodate some weird Windows errors for extra spacing

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Changed the NODE_ENV for the start-windows script to development from test
  • Added trim() function to process.env.NODE_ENV

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@tektaxi
Copy link
Contributor

tektaxi commented Nov 20, 2025

@MubeenMohammed please rebase from dev so it is only your intended commits

@MubeenMohammed
Copy link
Author

MubeenMohammed commented Nov 20, 2025

@tektaxi Done! I merged the dev branch into my branch, but I am not sure why these old commits are showing up. Maybe because I used merge instead of rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants