Skip to content

[Eep] rebase to incorporate comment history#3

Open
h-w-chen wants to merge 2 commits into
masterfrom
ddd
Open

[Eep] rebase to incorporate comment history#3
h-w-chen wants to merge 2 commits into
masterfrom
ddd

Conversation

@h-w-chen
Copy link
Copy Markdown
Owner

@h-w-chen h-w-chen commented Jun 26, 2018

test whether rebase will keep the comment history when commit hash changed

@h-w-chen h-w-chen self-assigned this Jun 26, 2018
@h-w-chen h-w-chen force-pushed the ddd branch 4 times, most recently from 71c3554 to 70a59db Compare June 26, 2018 21:17
h-w-chen
h-w-chen commented Jun 26, 2018
View reviewed changes
Copy link
Copy Markdown
Owner Author

@h-w-chen h-w-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to my line comment?

Comment thread README.md
$ git clone https://github.com/lxguru/xxx
```

after the rebase?
Copy link
Copy Markdown
Owner Author

@h-w-chen h-w-chen Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shou them be one liner?

Comment thread README.md
$ git clone https://github.com/lxguru/xxx
```

github feature or bug...
Copy link
Copy Markdown
Owner Author

@h-w-chen h-w-chen Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is my previous comment?

Copy link
Copy Markdown
Owner Author

@h-w-chen h-w-chen Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you still see that?

h-w-chen
h-w-chen commented Jun 26, 2018
View reviewed changes
Comment thread README.md
```
also change

github feature or bug...
Copy link
Copy Markdown
Owner Author

@h-w-chen h-w-chen Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my line comment????

@h-w-chen h-w-chen force-pushed the ddd branch 4 times, most recently from 71c3554 to 70a59db Compare June 26, 2018 21:29
@h-w-chen
Copy link
Copy Markdown
Owner Author

h-w-chen commented Jul 10, 2019

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@h-w-chen h-w-chen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@h-w-chen