Enhances I18NCreator for creating Message interfaces from properties #10166
+194
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Oct 23, 2025
There was a problem hiding this comment.
This appears to be in the style of other existing Creator types, so I can't fault it there, but I would generally like the test to be a bit more than 'it can run and doesn't fail in obvious ways' - at a glance, it doesn't even check if the generated sources compile?
A few things to consider below - thank you for getting this patch going again, I'd be inclined to merge it without further additional delay. If you'd like a more rigorous review, I'd be happy to.
user/src/com/google/gwt/i18n/rebind/AbstractLocalizableInterfaceCreator.java
Outdated
Show resolved
Hide resolved
user/src/com/google/gwt/i18n/rebind/MessagesInterfaceCreator.java
Outdated
Show resolved
Hide resolved
user/src/com/google/gwt/i18n/rebind/MessagesInterfaceCreator.java
Outdated
Show resolved
Hide resolved
Currently I18NCreator creates method signatures that only use String
arguments regardless of any MessageFormat that may be present for
an argument. This patch attempts to create more accurate interface
signatures based on the MessageFormat and also includes some GWT
specific formats such as {0,list},{0,localdatetime,..} and Plurals.
This patch also proposes to add the convention {0,safehtml} to mark that
an argument to be of type SafeHtml. If an Argument is found to be of
type SafeHtml the return type of the method will be set to SafeHtml.
Currently I18NCreator creates method signatures that only use String
arguments regardless of any MessageFormat that may be present for
an argument. This patch attempts to create more accurate interface
signatures based on the MessageFormat and also includes some GWT
specific formats such as {0,list},{0,localdatetime,..} and Plurals.
This patch also proposes to add the convention {0,safehtml} to mark that
an argument to be of type SafeHtml. If an Argument is found to be of
type SafeHtml the return type of the method will be set to SafeHtml.
|
Updated with recommendations from comments above. I am not inclined to take on rewriting Creator tests. Let me know if anything else needs updating to current style or implementation guidelines. |
niloc132
reviewed
Oct 23, 2025
user/src/com/google/gwt/i18n/rebind/MessagesInterfaceCreator.java
Outdated
Show resolved
Hide resolved
user/src/com/google/gwt/i18n/rebind/AbstractLocalizableInterfaceCreator.java
Show resolved
Hide resolved
Currently I18NCreator creates method signatures that only use String
arguments regardless of any MessageFormat that may be present for
an argument. This patch attempts to create more accurate interface
signatures based on the MessageFormat and also includes some GWT
specific formats such as {0,list},{0,localdatetime,..} and Plurals.
This patch also proposes to add the convention {0,safehtml} to mark that
an argument to be of type SafeHtml. If an Argument is found to be of
type SafeHtml the return type of the method will be set to SafeHtml.
niloc132
added
the
ready
niloc132
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I18NCreator creates method signatures that only use String arguments regardless of any MessageFormat that may be present for an argument. This patch attempts to create more accurate interface signatures based on the MessageFormat and also includes some GWT specific formats such as {0,list},{0,localdatetime,..} and Plurals.
This patch also proposes to add the convention {0,safehtml} to mark that an argument to be of type SafeHtml. If an Argument is found to be of type SafeHtml the return type of the method will be set to SafeHtml.
Fixes #9049