#127 adding cancel button#213
Open
CiTRuS93 wants to merge 8 commits into
Open
Conversation
Added ESLint comment rules
guytepper
requested changes
Nov 18, 2020
| editMode = null, | ||
| isAdmin, | ||
| }) { | ||
| let history = useHistory(); |
Owner
There was a problem hiding this comment.
Suggested change
| let history = useHistory(); | |
| const history = useHistory(); |
| }, [coordinatesUpdater]); | ||
|
|
||
| const onCancel = () => { | ||
| history.goBack(); |
Owner
There was a problem hiding this comment.
Pardon, I take back my words about the confirmation message.
Add a confirm dialog that says "המידע שהזנת לא יישמר. לחזור אחורה?"
Contributor
Author
There was a problem hiding this comment.
I was prepared for that 😃
guytepper
requested changes
Nov 24, 2020
Owner
guytepper
left a comment
guytepper
left a comment
There was a problem hiding this comment.
Hi - some final adjustments:
- Change the button color to red (use
tomato). - Make sure when pressing cancel it goes to the protest page - if the user has just signed in it will return to the sign in page
Contributor
Author
Hey there, sorry but I didn't manage to figure out how user can go to the protestForm after signing in. |
Owner
|
They should go to the protest page; you can take the protest id from the pathname and use it to get to the protest page |
guytepper
reviewed
Dec 10, 2020
Owner
guytepper
left a comment
guytepper
left a comment
There was a problem hiding this comment.
Hey @CiTRuS93, have you seen #213 (comment) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.