Add JSON query expressions +semver: minor#218
Conversation
|
@nimble-turtle is attempting to deploy a commit to the guibranco's projects Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideExtends dynamic JSON querying to support full jsonpath-ng expressions (including filter expressions) by switching to the extended parser, adds coverage for filter-based selection behavior, and documents the new query capabilities. Sequence diagram for dynamic JSON progress query with filter expressionssequenceDiagram
actor Client
participant FlaskApp as Flask_app
participant View as get_progress_svg_dynamic_json
participant Normalizer as normalize_jsonpath_query
participant HTTP as Remote_JSON_service
participant JSONPath as jsonpath_ng_ext_parse
Client->>FlaskApp: HTTP GET /progress.svg?url=...&query=$.progress[?(@.data.language.name=='Spanish')].data.translationProgress
FlaskApp->>View: Dispatch request
View->>HTTP: Fetch JSON from url
HTTP-->>View: JSON document
View->>Normalizer: normalize_jsonpath_query(selector)
Normalizer-->>View: normalized JSONPath expression
View->>JSONPath: parse(normalized_expression)
JSONPath-->>View: Compiled JSONPath with filter support
View->>View: Apply JSONPath to JSON document
View->>FlaskApp: Render SVG with extracted progress value
FlaskApp-->>Client: SVG response
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe PR extends JSONPath support in the JSON URL route to include full filter expressions (using ChangesJSONPath Filter Expression Support
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Secrets | May 5, 2026 4:08a.m. | Review ↗ | |
| Python | May 5, 2026 4:08a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
Failed to generate code suggestions for PR |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@gstraccini review |
|
Reviewing this pull request! 👀 Commits included: |
|
This pull request is ready ✅ for merge/squash. |
📑 Description
Slight change to allow jquery expressions instead of just jquery paths on the JSON.
✅ Checks
☢️ Does this introduce a breaking change?
Summary by Sourcery
Extend dynamic JSON querying to support full JSONPath filter expressions and update documentation and tests accordingly.
New Features:
Enhancements:
Tests:
Summary by CodeRabbit
New Features
/dynamic/json/endpoint, enabling more flexible data selection using sibling field matching instead of hardcoded indices.Documentation
Tests