Skip to content

[BUG] Progress number color has no effect#210

Merged
guibranco merged 2 commits into
mainfrom
bugfix/209-bug-progress_number_color-has-no-effect
Apr 17, 2026
Merged

[BUG] Progress number color has no effect#210
guibranco merged 2 commits into
mainfrom
bugfix/209-bug-progress_number_color-has-no-effect

Conversation

@guibranco

@guibranco guibranco commented Apr 17, 2026

Copy link
Copy Markdown
Owner

📑 Description

Closes #209

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

☢️ Does this introduce a breaking change?

  • Yes
  • No

Summary by Sourcery

Documentation:

  • Update README to reflect the correct default value for the progress_number_color option.

@guibranco guibranco linked an issue Apr 17, 2026 that may be closed by this pull request
@vercel

vercel Bot commented Apr 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
progressbar Ready Ready Preview, Comment Apr 17, 2026 2:50pm

@sourcery-ai

sourcery-ai Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes the progress number color behavior so that the configured color is actually applied in the SVG output and updates the README to document the new default color for the progress number.

Sequence diagram for applying progress_number_color in SVG generation

sequenceDiagram
    actor User
    participant Client
    participant ProgressService
    participant TemplateRenderer

    User->>Client: Request progress badge with progress_number_color
    Client->>ProgressService: HTTP GET /progress?progress_number_color=ffffff
    ProgressService->>ProgressService: Parse query parameters
    ProgressService->>ProgressService: Determine numberColor (param or default)
    ProgressService->>TemplateRenderer: Render progress.svg(numberColor, progress, otherParams)
    TemplateRenderer-->>ProgressService: SVG content with numberColor applied
    ProgressService-->>Client: HTTP 200 SVG response
    Client-->>User: Display badge with correct number color
Loading

Flow diagram for handling progress_number_color parameter

flowchart TD
    A[Start request] --> B[Read progress_number_color from query]
    B --> C{progress_number_color provided?}
    C -- Yes --> D[Validate hex color]
    C -- No --> E[Use default progress_number_color ffffff]
    D --> F{Valid?}
    F -- Yes --> G[Set numberColor to provided value]
    F -- No --> E
    E --> H[Inject numberColor into progress.svg template]
    G --> H
    H --> I[Render SVG output]
    I --> J[Return SVG response]
    J --> K[End]
Loading

File-Level Changes

Change Details Files
Ensure progress number color setting is applied correctly in the SVG template and align docs with the actual default.
  • Update the README documentation to state the correct default progress number color as white instead of black.
  • Adjust the progress.svg template so the progress_number_color parameter is bound to the text/number fill color, ensuring user-specified colors take effect.
README.md
templates/progress.svg

Assessment against linked issues

Issue Objective Addressed Explanation
#209 Make the progress_number_color query parameter correctly control the rendered progress number color instead of always showing white text.
#209 Update the documentation so that the documented default value for progress_number_color matches the actual default behavior.

Possibly linked issues

  • [BUG] progress_number_color has no effect #209: They address the same progress_number_color bug; PR corrects the documented default color related to the issue.
  • #: PR fixes progress_number_color so color customization works as requested in the issue, updating documentation accordingly.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@guibranco guibranco enabled auto-merge (squash) April 17, 2026 14:50
@gstraccini gstraccini Bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Apr 17, 2026
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@guibranco has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61dc34b0-b21e-4674-ae44-095b579e9822

📥 Commits

Reviewing files that changed from the base of the PR and between ab42946 and 5c562ea.

⛔ Files ignored due to path filters (1)
  • templates/progress.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/209-bug-progress_number_color-has-no-effect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gstraccini gstraccini Bot added hacktoberfest Participation in the Hacktoberfest event 🐛 bug Issues related to bugs or errors 📝 documentation Tasks related to writing or updating documentation 🔍 under investigation Issue or bug report is under investigation 🕒 low effort A task that can be completed in a few minutes labels Apr 17, 2026
@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2026
@deepsource-io

deepsource-io Bot commented Apr 17, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in ab42946...5c562ea on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Secrets Apr 17, 2026 2:50p.m. Review ↗
Python Apr 17, 2026 2:50p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Please ensure the default progress_number_color value in the rendering logic/template is updated to ffffff as well so that the documented default in the README stays consistent with the actual behavior.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Please ensure the default `progress_number_color` value in the rendering logic/template is updated to `ffffff` as well so that the documented default in the README stays consistent with the actual behavior.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@penify-dev

penify-dev Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@guibranco guibranco disabled auto-merge April 17, 2026 14:50
@github-actions

Copy link
Copy Markdown
Contributor

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
2026-04-17T14:50:59Z INF scanning for exposed secrets...
2:50PM INF 134 commits scanned.
2026-04-17T14:50:59Z INF scan completed in 22.2ms
2026-04-17T14:50:59Z INF no leaks found

@guibranco guibranco enabled auto-merge (squash) April 17, 2026 14:51
@guibranco guibranco merged commit 0b35724 into main Apr 17, 2026
19 of 20 checks passed
@guibranco guibranco deleted the bugfix/209-bug-progress_number_color-has-no-effect branch April 17, 2026 14:51
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@guibranco

Copy link
Copy Markdown
Owner Author
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🐛 bug Issues related to bugs or errors 📝 documentation Tasks related to writing or updating documentation hacktoberfest Participation in the Hacktoberfest event 🕒 low effort A task that can be completed in a few minutes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. 🔍 under investigation Issue or bug report is under investigation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] progress_number_color has no effect

1 participant