This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Introduce CF param for verssion of config #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the version was hard-coded to "master" and fetched directly out of Github. This meant that if a new instance was brought up after the master branch had changed, the instance would be running different config to the rest of the cluster. Generally this would break the cluster.
Contributor
|
👍 from me ... @TBonnin any objections? |
Contributor
|
It is better for sure but still easy to shoot yourself in the foot by using the default 'master' value. I wonder if we should find a way to set this commit hash automatically. For instance a |
Contributor
Author
|
I'm sure a post-merge hook wouldn't do what people expect. Let's chat about it IRL, after stand up? |
Member
|
sounds better to me, although getting it from the build output would make more sense than from git directly, I'm not a big fan of automatically writing back to git if that's what the suggestion is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the version was hard-coded to "master" and fetched directly out of Github. This meant that if a new instance was brought up after the master branch had changed, the instance would be running different
config to the rest of the cluster. Generally this would break the cluster.