Consolidate Playwright tests#507
Draft
cemms1 wants to merge 5 commits into
Draft
Conversation
Visual regression testing results 🔍If any tests are failing, please check that any visual changes are intentional before merging your PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This combines all Playwright tests into one file, using a configuration file to supply the templates to take snapshots of.
There are no longer two tests per template, just one. This better reflects the situation since we are only testing "one" thing. Taking a snapshot is not really a test in itself. We need the before/after comparison for it to count as a test.
These tests run in parallel and save the snapshot data in the same way.
Fabric expandable and Fabric custom needed small adaptations in order to get these to work properly. These are included as
ifstatements in the test.💡 It might be nice to improve upon this by automatically testing all directories in the
templatescsrandssrdirectories