Notify user of error and that examples are not run#399
Open
wnuqui wants to merge 1 commit intoguard:masterfrom
Open
Notify user of error and that examples are not run#399wnuqui wants to merge 1 commit intoguard:masterfrom
wnuqui wants to merge 1 commit intoguard:masterfrom
Conversation
houndci-bot
reviewed
Jul 6, 2017
lib/guard/rspec/rspec_process.rb
Outdated
| _parse_summary(results.summary) | ||
|
|
||
| !all_green? && \ | ||
| example_count == 0 && failure_count == 0 && pending_count == 0 |
There was a problem hiding this comment.
Use example_count.zero? instead of example_count == 0.
Use failure_count.zero? instead of failure_count == 0.
Use pending_count.zero? instead of pending_count == 0.
1 similar comment
houndci-bot
reviewed
Jul 6, 2017
spec/lib/guard/rspec/runner_spec.rb
Outdated
| allow(process).to receive(:error_and_examples_not_run?).and_return(true) | ||
|
|
||
| expect(notifier).to receive(:notify_failure) | ||
| .with(/Error\/s occurred and examples are not run./) |
wnuqui
changed the title
wnuqui
force-pushed
the
fix/notify-that-there-is-error-and-examples-are-not-run
branch
from
60d3319 to
f201035
Compare
houndci-bot
reviewed
Jul 6, 2017
spec/lib/guard/rspec/runner_spec.rb
Outdated
| allow(process).to receive(:error_and_examples_not_run?).and_return(true) | ||
|
|
||
| expect(notifier).to receive(:notify_failure) | ||
| .with(/Error\/s occurred and examples are not run./) |
lib/guard/rspec/rspec_process.rb
Outdated
| # Returns true if there is an error AND examples are not run. | ||
| def error_and_examples_not_run? | ||
| error = "error occurred outside of examples" | ||
| summary_regexp = %r{0 examples, 0 failures( \((\d+) #{error}\))?} |
houndci-bot
reviewed
Jul 6, 2017
spec/lib/guard/rspec/runner_spec.rb
Outdated
| allow(process).to receive(:error_and_examples_not_run?).and_return(true) | ||
|
|
||
| expect(notifier).to receive(:notify_failure) | ||
| .with(/Error\/s occurred and examples are not run./) |
lib/guard/rspec/rspec_process.rb
Outdated
| # Returns true if there is an error AND examples are not run. | ||
| def error_and_examples_not_run? | ||
| error = "error occurred outside of examples" | ||
| summary_regexp = %r{0 examples, 0 failures( \((\d+) #{error}\))?} |
wnuqui
force-pushed
the
fix/notify-that-there-is-error-and-examples-are-not-run
branch
from
f201035 to
b5cce3e
Compare
1 similar comment
wnuqui
force-pushed
the
fix/notify-that-there-is-error-and-examples-are-not-run
branch
from
b5cce3e to
7a2fd06
Compare
1 similar comment
|
👍 |
|
@e2 are you still the maintainer? if so, please review & merge! |
|
👍 |
1 similar comment
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398, now user is correctly notified of error and that examples are not run.
Before
After
Please review, thanks!