[WIP] fix for RSpec deprecation warning, take III

[afeld]

Follow-up to #328, which didn't do the trick unfortunately. Still getting the same error as #327 (comment), because metadata[:parent_example_group] is still being accessed.

[houndci-bot]

Unused block argument - hsh. If it's necessary, use _ or _hsh as an argument name to indicate that it won't be used.
Space missing to the left of {.
Space between { and | missing.

[e2]

Be sure to check out: https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18

quote:

Restructure example group metadata so that the computed keys are exposed directly off of the metadata hash rather than being on a nested :example_group subhash. In addition, the parent example group metadata is now available as [:parent_example_group] rather than [:example_group][:example_group]. Deprecated access via the old key structure is still provided. (Myron Marston)

Ideally, provide the metadata you have that's creating the deprecation.

It's one thing to avoid the deprecation, it's another to get the location properly regardless of the RSpec version - it's best to have an extra spec that demonstrates how to get the deprecation.

From what I understand, accessing :parent_example_group is fine (as opposed to using :example_group).

With this code, :parent_example_group should be used, which should not trigger the deprecation, as is here:

guard-rspec/lib/guard/rspec_formatter.rb

Line 36 in 0e34593

metadata = metadata[:parent_example_group] || metadata[:example_group]

Anyway, I'm a bit confused about the issue. Good specs would help.

[e2]

If you can, extract the example with the deprecation into a repo, and I'll check it out - I don't like the way the implementation iterates to get the location, but I want to reproduce your exact scenario (example, nesting, file, whether you're using shared examples or not) before I change anything.

[e2]

Maybe an update: if you're using RSpec 3.3.x, you shouldn't have the deprecations, because this line should always be true:

guard-rspec/lib/guard/rspec_formatter.rb

Line 35 in 0e34593

until spec_path?(location)

(This means, if you're getting the deprecations, then somehow strangely spec_path? is returning false - which seems wrong).

You can also config.raise_errors_for_deprecations! in your spec/spec_helper.rb to help stop as soon as the error occurs.

[e2]

The deprecation error is likely because of this: #338