Fix voice recognition missing this.props after arrow function removed#20
Open
stahlmanDesign wants to merge 3 commits intogrvcoelho:masterfrom
Open
Fix voice recognition missing this.props after arrow function removed#20stahlmanDesign wants to merge 3 commits intogrvcoelho:masterfrom
stahlmanDesign wants to merge 3 commits intogrvcoelho:masterfrom
Conversation
…ed them for better use. reformatted the functions into es2015 notation
made changes to the voiceplayer.js and voicerecognition.js files, fix…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix that removed arrow functions to be compatible with common js changed the scope for
thisin the bindResult method. Now props are bound to the eventListener and sent as an argument