Don't popTransaction unless it was pushed#1066
Open
MrLIVB wants to merge 1 commit into
Open
Conversation
…nal to obtainConnection
badgerwithagun
requested changes
Jul 19, 2026
badgerwithagun
left a comment
badgerwithagun
left a comment
Member
There was a problem hiding this comment.
Thanks @MrLIVB! Good spot. There's a small tweak needed then this is good to merge.
| try { | ||
| return work.doWork(transaction); | ||
| } finally { | ||
| popTransaction(); |
Member
There was a problem hiding this comment.
Now we need to be similarly careful about connection.setAutoCommit(autoCommit);. If pushTransaction or popTransaction throw, the connection will be left with a corrupted autocommit setting. Another nested try...finally is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1065
Reorganizes code inside of
SimpleTransactionManagerTest.withTransactionsopopTransactionisn't called infinallyblock of connection acquiring.