plumb otel subchannel metrics disconnect error #12342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgraVator
commented
Sep 10, 2025
binder/src/main/java/io/grpc/binder/internal/BinderClientTransport.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Sep 18, 2025
binder/src/main/java/io/grpc/binder/internal/BinderClientTransport.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/ClientTransportWithDisconnectReason.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void shutdownNow(final Status reason) { | ||
| shutdownNow(reason, SimpleDisconnectError.UNKNOWN); |
|
|
||
| @Override | ||
| public void shutdownNow(Status reason) { | ||
| shutdownNow(reason, SimpleDisconnectError.UNKNOWN); |
|
|
||
| @Override | ||
| public void shutdownNow(Status reason, DisconnectError disconnectError) { | ||
| shutdown(reason); |
There was a problem hiding this comment.
disconnectError looks like it should be passed to be passed to shutdown.
| ArgumentCaptor<Status> captor = ArgumentCaptor.forClass(Status.class); | ||
| verify(listener, timeout(TIME_OUT_MS)).transportShutdown(captor.capture()); | ||
| verify(listener, timeout(TIME_OUT_MS)).transportShutdown(captor.capture(), | ||
| any(DisconnectError.class)); |
There was a problem hiding this comment.
Probably want to consider verifying the DisconnectError as well, for this and the other three below that use captor.capture().
AgraVator
force-pushed
the
plumb-otel-subchannel-metrics-disconnect-error
branch
2 times, most recently
from
b6dce83 to
339ef99
Compare
AgraVator
force-pushed
the
plumb-otel-subchannel-metrics-disconnect-error
branch
from
4df2777 to
2c3b757
Compare
|
last reviewed till 44fc3f9 |
ejona86
reviewed
Oct 15, 2025
| goAwayStatus = reason; | ||
| listener.transportShutdown(goAwayStatus, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN); | ||
| stopIfNecessary(); | ||
| } |
There was a problem hiding this comment.
Seems this method should just be shutdown(reason, SimpleDisconnectError.SUBCHANNEL_SHUTDOWN). I don't know why it was made to have a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes the remaining work of A94