feat(Gallery): add image scaling #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
d3m1d0v
force-pushed
the
gallery-image-zoom
branch
from
13fbcf0 to
605bac4
Compare
d3m1d0v
force-pushed
the
gallery-image-zoom
branch
from
ccdf0b6 to
fef5ed8
Compare
kseniya57
reviewed
Dec 11, 2025
| @@ -0,0 +1,7 @@ | |||
| // Constants | |||
Contributor
There was a problem hiding this comment.
It would be good to delete all unnecessary comments, for example, here it is clear from the file that these are constants, and from the name of each constant it is clear why it is needed.
| export type GalleryItemAction = { | ||
| id: string; | ||
| title: string; | ||
| title: string | WithTFn; |
Contributor
There was a problem hiding this comment.
Why do we need the function?
src/components/Gallery/hooks/useImageZoom/useImageZoomDesktop.ts
Outdated
Show resolved
Hide resolved
| return; | ||
| } | ||
|
|
||
| e.stopPropagation(); |
Contributor
There was a problem hiding this comment.
This can break closing popups logic (if we render the dropdown in the top right corner of the gallery)
d3m1d0v
force-pushed
the
gallery-image-zoom
branch
from
fef5ed8 to
2c99334
Compare
kseniya57
reviewed
Dec 12, 2025
| import {checkImageFitsContainer, createConstrainPosition} from './utils'; | ||
|
|
||
| // blank props for further options | ||
| export type UseImageZoomProps = {}; |
Contributor
There was a problem hiding this comment.
I suggest not adding the props until they are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added zoom for images in
<Gallery/>component for desktop and touch devices.Also fixed usage of
useTranslation()hook insidegetGalleryItemCopyLinkActionandgetGalleryItemDownloadAction()