Skip to content

feat(Stories)!: remove deprecated description param #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mytwink wants to merge 6 commits into
base: release/v4
Choose a base branch
from
Open

feat(Stories)!: remove deprecated description param #228

mytwink wants to merge 6 commits into from

Conversation

@mytwink
Copy link
Contributor

@mytwink mytwink commented Oct 15, 2024

No description provided.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Oct 15, 2024

Preview is ready.

@mytwink mytwink marked this pull request as ready for review October 16, 2024 07:10
korvin89
korvin89 requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@korvin89 korvin89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why it is chore?
  2. It should be added to the next branch, not to the main

@mytwink
Copy link
Contributor Author

mytwink commented Oct 16, 2024

  1. Why it is chore?
  2. It should be added to the next branch, not to the main
  1. Which tag would be more correct? feat?
  2. I can't find the next branch, do I need to create it myself or do you mean release/v4?

@mytwink mytwink requested a review from korvin89 October 16, 2024 11:41
@korvin89
Copy link
Contributor

korvin89 commented Oct 16, 2024

  1. Why it is chore?
  2. It should be added to the next branch, not to the main
  1. Which tag would be more correct? feat?
  2. I can't find the next branch, do I need to create it myself or do you mean release/v4?
  1. feat
  2. Yep, release/v4

@mytwink mytwink changed the base branch from main to release/v4 October 18, 2024 08:30
@mytwink mytwink changed the title chore(Stories)!: remove deprecated description param feat(Stories)!: remove deprecated description param Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkGenius DarkGenius Awaiting requested review from DarkGenius DarkGenius is a code owner

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mytwink @gravity-ui-bot @korvin89 @jhoncool @melikhov-dev