Modernize Codebase for Better Compatibility#138
Open
Rajdeep-naha wants to merge 1 commit intograspnet:mainfrom
Open
Modernize Codebase for Better Compatibility#138Rajdeep-naha wants to merge 1 commit intograspnet:mainfrom
Rajdeep-naha wants to merge 1 commit intograspnet:mainfrom
Conversation
- Replace deprecated NumPy types (np.bool, np.int) with modern alternatives - Improve CLI with argparse for better usability - Enhance error handling and logging - Update KNN C++/CUDA extensions for cross-platform compatibility - Add comprehensive .gitignore for cleaner repository - Fix file path handling for cross-platform support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. NumPy Compatibility Updates
np.bool→boolornp.bool_np.int→intornp.int64np.float→floatornp.float642. C++/CUDA KNN Extension Improvements
longwithint64_tin all C++/CUDA files#include <cstdint>for fixed-width integer typesknn.hcpu/vision.hcuda/vision.hcpu/knn_cpu.cppcuda/knn.cu3. CLI and Error Handling
argparsefor flexible command-line argumentsos.path.join()4. File Path and Cross-Platform Fixes
os.path.join()data_utils.pygraspnet_dataset.pydemo.py5. Code Quality and Maintenance
.gitignore:6. Testing and Verification
Files Changed
Python Files:
demo.pydataset/graspnet_dataset.pyutils/data_utils.pyutils/loss_utils.pyC++/CUDA Files:
knn/src/knn.hknn/src/cpu/vision.hknn/src/cpu/knn_cpu.cppknn/src/cuda/vision.hknn/src/cuda/knn.cuConfiguration:
.gitignoreNotes for Reviewers