add initial outline for field extensions #1196
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| - extend field MemberCoordinate Directives[const]? | ||
| - extend field description MemberCoordinate |
There was a problem hiding this comment.
Was the intent to have the ability to add a description to fields? The other extensions don't allow that. What happens if the field already has a description? I suggest we only allow adding directives:
| - extend field MemberCoordinate Directives[const]? | |
| - extend field description MemberCoordinate | |
| - extend field MemberCoordinate Directives[Const] |
There was a problem hiding this comment.
This was suggested by @benjie on Discord. I think it makes sense, especially in an AI age where descriptions give valuable info to LLMs. But true it needs validation rules.
There was a problem hiding this comment.
Thanks for the heads up 👍.
Interesting! Although I would find it a bit odd to allow adding descriptions on fields but not on types and more (maybe this should go to a different PR that does that more broadly and keep this one focused on directives).
If we do want to keep this I think the grammar should look like:
| - extend field MemberCoordinate Directives[const]? | |
| - extend field description MemberCoordinate | |
| - extend field MemberCoordinate Directives[Const] | |
| - extend field Description MemberCoordinate |
3 participants
https://github.com/graphql/graphql-wg/blob/main/rfcs/FieldExtensions.md
#1162