This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Added resolver-returned value to the error object, plus further docum… #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation on expected error fields (graphql#590)
| - **message:** the error message | ||
| - **locations:** the location(s) in the Javascript code where the error ocurred | ||
| - **path:** the path within the returned results where the error occurred (eg. in a schema violation error, the path to the part of the results that violated the schema) | ||
| - **result:** the value which was returned by the resolver (if any) |
There was a problem hiding this comment.
@machineghost Don't think we have it on any of errors?
|
|
||
| - **message:** the error message | ||
| - **locations:** the location(s) in the Javascript code where the error ocurred | ||
| - **path:** the path within the returned results where the error occurred (eg. in a schema violation error, the path to the part of the results that violated the schema) |
There was a problem hiding this comment.
What do you mean by schema violation error?
| Although the fields on the error provided to this function may vary (based on the error type), they will typically include: | ||
|
|
||
| - **message:** the error message | ||
| - **locations:** the location(s) in the Javascript code where the error ocurred |
There was a problem hiding this comment.
It should be locations inside query/SDL string not inside JS code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation on expected error fields (#590)