[tests] Add testltp program to enable testing with newer LTP versions - #2118
Draft
efu39 wants to merge 1 commit into
Draft
[tests] Add testltp program to enable testing with newer LTP versions#2118efu39 wants to merge 1 commit into
efu39 wants to merge 1 commit into
Conversation
kailun-qin
reviewed
Apr 9, 2025
kailun-qin
left a comment
Contributor
There was a problem hiding this comment.
@efu39: Can we discuss this in the next core Gramine meeting?
Reviewable status: 0 of 4 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
This is a draft PR, to get input if there is interest to merge it.
With the LTP 1909cd5675 change, the command
gramine-{direct|sgx} <TEST_BINARY>does not work with LTP releases after 20220527, failing with “TFAIL: Main test process might have exit”The commit introduces testltp program, allowing newer versions of LTP to be tested using:
gramine-{direct|sgx} testltp <TEST_BINARY>Additionally, testing with pytest can be done by setting the LTP_ENV variable, for example:
LTP_ENV=testltp python3 -m pytest -v -k chmod01 LTP_ENV=testltp make [SGX=1] regressionThe change enables testing with newer LTP versions for development purposes only. The LTP version in use remains unchanged.
How to test this PR?
For the current LTP version, LTP test behave as before and can be run with:
make [SGX=1] regressionTested with LTP version 20240930 using:
LTP_ENV=testltp make [SGX=1] regressionThis change is