ci: migrate to grafana/k6-ci#27
Open
mstoykov wants to merge 4 commits into
Open
Conversation
Replace the grafana/xk6 extension-validate workflow with a call to grafana/k6-ci/.github/workflows/all.yml, matching the rest of the migrated k6 extensions.
Rework the cdo-generated lint target to download .golangci.yml from grafana/k6-ci at the ref pinned in the workflow and run golangci-lint at its pinned version, with an optional .golangci.patch overlay. Adds update-lint-patch and clean-lint helpers. See grafana/k6-ci/README.md.
The k6-ci .golangci.yml is stricter than the previous per-repo config. Fixes: drop dead code, return the unchecked write error, and add //nolint:forbidigo for legitimate os usage in tests and CLI helper tools.
`make lint` now writes .golangci-base.yml and .golangci.yml at the repo root (gitignored), matching grafana/k6-ci/templates/Makefile, instead of under build/lint. The previously committed per-repo .golangci.yml is removed: both CI and `make lint` use the canonical config downloaded from grafana/k6-ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the grafana/xk6 extension-validate workflow with a call to grafana/k6-ci/.github/workflows/all.yml (pinned to v0.3.0), matching the rest of the migrated k6 extensions.