Skip to content

Conversation

oleg-kozlyuk-grafana
Copy link
Contributor

No description provided.

This comment has been minimized.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-kozlyuk-grafana oleg-kozlyuk-grafana enabled auto-merge (squash) October 10, 2025 08:23
@oleg-kozlyuk-grafana oleg-kozlyuk-grafana merged commit 7dc3dc4 into main Oct 10, 2025
20 checks passed
@oleg-kozlyuk-grafana oleg-kozlyuk-grafana deleted the otlp-update branch October 10, 2025 08:29
@marcsanmi
Copy link
Contributor

I think the current logic doesn't handle locations with empty Line arrays (unsymbolized). When len(ol.Line) == 0, the inner loop never runs, so hasFunctions stays true. This prevents blocks from being tagged as unsymbolized, causing the symbolizer to never run - when enabled. This affects both fully unsymbolized profiles and mixed-symbolization cases (where some locations are symbolized, some aren't). We could check if len(ol.Line) == 0 before the loop and set all flags to false

@oleg-kozlyuk-grafana
Copy link
Contributor Author

I think the current logic doesn't handle locations with empty Line arrays (unsymbolized). When len(ol.Line) == 0, the inner loop never runs, so hasFunctions stays true. This prevents blocks from being tagged as unsymbolized, causing the symbolizer to never run - when enabled. This affects both fully unsymbolized profiles and mixed-symbolization cases (where some locations are symbolized, some aren't). We could check if len(ol.Line) == 0 before the loop and set all flags to false

Fair point point. I don't think opentelemetry-collector currently produces frames like that, but we might encounter clients with different interpretation of standard. Raised #4517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants