Add dependency check to Makefile #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new Bash script `dependancy_check.sh` has been added to ensure that the minimum required Bash version is used. This script is now called in the Makefile as part of the `check_dependencies` task. This aims to prevent errors due to incompatible Bash versions.
The `dependancy_check.sh` script has been expanded to improve the verification process. It not only checks the running bash version for compatibility, but also ensures that a set list of commands are available before proceeding. This eliminates potential breakdowns due to missing dependencies or unsupported bash versions.
Reshaped the DEVELOPMENT.md file to provide thorough and more explicit instructions. Each section is now easily accessible and comprehensible, eliminating any potential ambiguity for the user. This streamlines the development process by clearly laying out instructions for checking dependencies, generating Jsonnet libraries and documents, as well as understanding usage of the Grafonnet-base library and examples.
|
|
|
Thanks of this, the |
|
I've been thinking about this, perhaps it would be much safer to pour this all into a container image rather than expecting a local development environment. WDYT? |
|
@Duologic I agree moving to a dev container would be a much better way to handle it. May I suggest creating a Dev container or multiple? Plus makes for great integration in most popular IDE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Bash script
dependancy_check.shhas been added to ensure that the minimum required Bash version is used and that required commands used by generate are available. This script is now called in the Makefile as part of thecheck_dependenciestask. This aims to prevent errors due to incompatible Bash versions or missing commands.After encountering some minor inconvenience debugging why then
generate.shscript was failing, I added this script to ensure others don't waste any time.Also, minor clean up of the Development readme.