Skip to content

Fix(NotificationPolicy): Remove invalid fields under .spec.route #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix(NotificationPolicy): Remove invalid fields under .spec.route #2270

wants to merge 2 commits into from

Conversation

@Baarsgaard
Copy link
Collaborator

@Baarsgaard Baarsgaard commented Nov 2, 2025 •
edited
Loading

@Baarsgaard
fix: Split Route into PartialRoute containing top-level fields
155a39a 
Removes a fields from .spec.route preventing users from defining them
and ending up with an invalid API request/DTO

Additionally, .spec.provenance is deprecated as it seemingly does nothing
@Baarsgaard
chore: Generate crds/docs
5eaf360
@github-actions github-actions bot added documentation Issues relating to documentation, missing, non-clear etc. bugfix this PR fixes a bug labels Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nissessenap nissessenap Awaiting requested review from nissessenap nissessenap will be requested when the pull request is marked ready for review nissessenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd will be requested when the pull request is marked ready for review weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn will be requested when the pull request is marked ready for review ishanjainn is a code owner

@theSuess theSuess Awaiting requested review from theSuess theSuess will be requested when the pull request is marked ready for review theSuess is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin will be requested when the pull request is marked ready for review hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 will be requested when the pull request is marked ready for review pb82 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bugfix this PR fixes a bug documentation Issues relating to documentation, missing, non-clear etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Baarsgaard