Skip to content

Format Referer header on X-Dashboard-Title and X-Panel-Title #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
velom wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Format Referer header on X-Dashboard-Title and X-Panel-Title #1433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6967f38
Format Referer header on X-Dashboard-Title and X-Panel-Title
velom Nov 6, 2025
5011611
typo fix
velom Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pkg/plugin/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ import (
"golang.org/x/net/proxy"
)

const (
headerDashboardTitle = "X-Dashboard-Title"
headerPanelTitle = "X-Panel-Title"
headerReferer = "Referer"
)

// Clickhouse defines how to connect to a Clickhouse datasource
type Clickhouse struct{}

Expand Down Expand Up @@ -439,6 +445,7 @@ func extractForwardedHeadersFromMessage(message json.RawMessage) (map[string]str
return nil, errors.New("Couldn't parse message as args")
}

var dashboard, panel string
httpHeaders := make(map[string]string)
if grafanaHttpHeaders, ok := messageArgs[sqlds.HeaderKey]; ok {
fwdHeaders, ok := grafanaHttpHeaders.(map[string]interface{})
Expand All @@ -458,9 +465,23 @@ func extractForwardedHeadersFromMessage(message json.RawMessage) (map[string]str
}

httpHeaders[k] = strings.Join(strHeadersArr, ",")

if k == headerDashboardTitle {
dashboard = httpHeaders[k]
}

if k == headerPanelTitle {
panel = httpHeaders[k]
}
}
}

if dashboard != "" || panel != "" {
httpHeaders[headerReferer] = fmt.Sprintf("Dashboard title: %q, panel title: %q", dashboard, panel)
} else {
httpHeaders[headerReferer] = "Explorer"
Copy link
Contributor

@aangelisc aangelisc Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically untrue; the query could also come from alerting. You should be able to validate this by checking the uname from the plugin context for grafana_scheduler.

}

return httpHeaders, nil
}

Expand Down