Use GEMM in L2 persistence CI test#51
Merged
Merged
Conversation
msaroufim
marked this pull request as ready for review
June 10, 2026 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the L2 persistence regression test to use a single-column GEMM (
torch.mm(w, x[:, None])) instead of GEMV (torch.mv). The RHS remains logically vector-shaped for the benchmark, but keeping it rank-2 avoids the flakycublasSgemvpath that failed in Modal L4 CI.Root cause
The failing GitHub Actions job hit
CUBLAS_STATUS_INVALID_VALUEinsidetorch.mv(w, x)while generating expected outputs fortest/l2_persistence.py. The previous lazy CUDA initialization fix moved the failure site but did not remove the fragile cuBLAS GEMV dispatch.Validation
python3 -m py_compile test/l2_persistence.pygit diff --check27183274114: passed, withl2_persistence.pyreportinghacked/honest median ratio = 0.998andOK: L2 persistence confers no benchmark advantage.l2_persistence.pyrerun 3 additional times with the same failed workflow wheel artifact: all passed.Notes
T4 is not a useful target for this regression test because Turing does not support the persisting-L2 behavior being exercised. L4 remains the intended CI target for this check.