Fix L2 persistence Modal CI test#50
Merged
Merged
Conversation
msaroufim
marked this pull request as ready for review
June 9, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the L2 persistence test's CUDA device queries, libcudart loading, and large weight allocation behind lazy process-local initialization. This avoids initializing CUDA at module import before the isolated benchmark subprocess/thread runs.
Root cause
The Modal L4 CI job failed in
test/l2_persistence.pywhentorch.mv(_W, x)raisedCUBLAS_STATUS_INVALID_VALUE. The test created_Wand queried CUDA globals at import time, then the benchmark harness spawned an isolated process and ran setup inside the native benchmark thread. Deferring that CUDA state creation keeps the test setup inside the process that uses it.Validation
python3 -m py_compile test/l2_persistence.py ci/modal_gpu_test.py python/pygpubench/__init__.pygit diff --checkl2_persistence.pycompleted withhacked/honest median ratio = 1.001andOK: L2 persistence confers no benchmark advantage.