feat: Display ftyp minor_version as number or 4CC #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO/IEC 23008-12:2025/DAmd 2 "Information technology — High efficiency coding and media delivery in heterogeneous environments — Part 12: Image File Format — Amendment 2: Low-overhead image file format" reuses the
minor_versionfield of theFileTypeBoxto store a brand in a similar manner asmajor_brandandcompatible_brands[].This is made possible by ISO/IEC FDIS 14496-12/DAmd 1 "Information technology — Coding of audio-visual objects — Part 12: ISO base media file format — Amendment 1: Tools for enhanced CMAF and DASH integration" which allows for arbitrary usage of
minor_versionin derived specifications depending on the major brand.This PR shows the
minor_versionfield as a number (current behavior) unless it is an alphanumeric 4CC (new behavior). Most existing files (at least HEIF-based ones) should haveminor_versionset to 0, and it is expected that files settingminor_versionto another value than 0 will be using it to store a brand.